Project

General

Profile

Actions
Copy link

Bug #5288

closed

x86 bitmap inline asm functions duplicate code

Added by Josef Sipek over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Josef Sipek
Category:
kernel
Start date:
2014-11-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

The inline assembly functions in uts/intel/asm/bitmap.h duplicate way too much code.

  1. don't duplicate inline assembly blocks unnecessarily
  2. drop __ from local variables
  3. atomic_btr32 can generate better code by using "m" constraint instead of "r"

Related issues

Related to illumos gate - Bug #5291: x86 {high,low}bit rely on undefined behaviorClosedJosef Sipek2014-11-06

Actions
Actions
Copy link
 #1

Updated by Electric Monk over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 70 to 100

git commit 7e33f252cf7e3c3ee6c4ad7a90480f5aea3a026c

commit  7e33f252cf7e3c3ee6c4ad7a90480f5aea3a026c
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-11-11T05:21:27.000Z

    5288 x86 bitmap inline asm functions duplicate code
    Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF