findunref is both slow and broken
tools - gate/build tools
The findunref support for git lost a condition that gated the retrieval of the git manifest on us not already having one, which means that we run 'git ls-files' many, many, many times. On i386 with a hot cache, this actually doesn't stand out. Should you try to use it on SPARC, however, it'll probably take a couple of hours...
In fixing this, we found another rather cute bug, whereby because we were regenerating the manifest per-directory, if we walked a directory such that we entered a subdirectory before processing all files, we may fail to process some of those files, leaving them as constant false negatives.
Updated by Electric Monk over 8 years ago
- Status changed from New to Closed
- % Done changed from 80 to 100
git commit b998737654179ec0e068e04f6fda6e76777171c9
commit b998737654179ec0e068e04f6fda6e76777171c9 Author: Richard Lowe <email@example.com> Date: 2014-11-16T20:32:28.000Z 5292 findunref is both slow and broken Reviewed by: Igor Kozhukhov <firstname.lastname@example.org> Reviewed by: Joshua Clulow <email@example.com> Reviewed by: Gordon Ross <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>