Project

General

Profile

Actions

Bug #5298

closed

fabs is 0-sized, confuses dis(1) and others

Added by Rich Lowe about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2014-11-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Because of the synonyms use in libm, fabs is defined to be __fabs

We have an asm implementation on i386, which does:

ENTRY(fabs)

but then needs to use the 'fabs' instruction, so does:

#undef fabs

And then when it's done does

SET_SIZE(fabs)

It never redefines fabs=__fabs though, so it sets the size of the wrong symbol (the weak one). Leaving the function symbol of incorrectly 0 size.

This confuses dis(1), me, and probably other things and people.

Actions

Also available in: Atom PDF