Project

General

Profile

Actions

Bug #5302

closed

vm: remove 'nopageage' static global

Added by Josef Sipek over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
kernel
Start date:
2014-11-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

With gcc 4.4.4, the situation is terrible. It doesn't matter if you are looking at debug or non-debug build, you'll see:

> nopageage::nm
Value              Size               Type  Bind  Other Shndx    Name
0xfffffffffb943e80|0x0000000000000004|OBJT |LOCL |0x0  |12      |nopageage
> page_free::dis ! grep nopageage
>

So, you can set the global with mdb all you want, it just won't do anything useful at all because the compiler propagated the apparently constant value into the one expression.

Looking at the history of that code, all I can say is the two lines in question (the static global and the if statement) predate OpenSolaris launch.

There are two possible actions:
  1. un-static-ify it
  2. remove it
    In the absence of anyone wanting to use it, it makes sense to remove it.

For completeness: studio keeps the global as well as the load & comparison in page_free.

Actions #1

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 70 to 100

git commit 8d4235fba682c56f12ea86ef87ad6d349013c637

commit  8d4235fba682c56f12ea86ef87ad6d349013c637
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-11-19T21:07:17.000Z

    5302 vm: remove 'nopageage' static global
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Marcel Telka <marcel.telka@nexenta.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF