Project

General

Profile

Actions
Copy link

Bug #5369

closed

arc flags should be an enum

Added by Matthew Ahrens over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Matthew Ahrens
Category:
zfs - Zettabyte File System
Start date:
2014-11-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

The arc uses several flags but they are defined in two different locations
which can lead to confusion and programming errors. Additionally, when looking
at the flags in a crash dump it would be nice to see the real name rather than
just a hex value. Converting them to an enum allows us to print flags in mdb
and avoid any potential programming error when a flag is defined in the wrong
location.

Actions
Copy link
 #1

Updated by Electric Monk over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 7adb730b589e553bf3b1ccfd9bae2df91c5c1061

commit  7adb730b589e553bf3b1ccfd9bae2df91c5c1061
Author: George Wilson <george.wilson@delphix.com>
Date:   2014-12-06T17:24:33.000Z

    5369 arc flags should be an enum
    5370 consistent arc_buf_hdr_t naming scheme
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Alex Reece <alex.reece@delphix.com>
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: Richard Elling <richard.elling@richardelling.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF