Project

General

Profile

Bug #5370

consistent arc_buf_hdr_t naming scheme

Added by Matthew Ahrens over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-11-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The arc has evolved over the years and it's evident that many developers have
added their own style. This can lead to confusion because arc_buf_hdr_t can be
named different things which sometimes overlap with other structures. Today
arc_buf_hdr_t's are often named hdr, buf, or ab. It gets confusing because
arc_buf_t's are often named buf as well. We should use 'hdr' when using an
arc_buf_hdr_t.

History

#1

Updated by Electric Monk over 5 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 7adb730b589e553bf3b1ccfd9bae2df91c5c1061

commit  7adb730b589e553bf3b1ccfd9bae2df91c5c1061
Author: George Wilson <george.wilson@delphix.com>
Date:   2014-12-06T17:24:33.000Z

    5369 arc flags should be an enum
    5370 consistent arc_buf_hdr_t naming scheme
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Alex Reece <alex.reece@delphix.com>
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: Richard Elling <richard.elling@richardelling.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF