Project

General

Profile

Actions

Bug #5383

closed

5234 breaks build on sparc

Added by Peter Tribble over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2014-12-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Building illumos-gate on sparc fails with the error below. This makes sense, the defines are from the intel regset.h and don't apply to sparc, and the whole of 5234 is pretty x86-specific.

../common/Pcore.c:511: error: 'REG_R15' undeclared (first use in this function)
../common/Pcore.c:511: error: (Each undeclared identifier is reported only once
../common/Pcore.c:511: error: for each function it appears in.)
../common/Pcore.c:512: error: 'REG_R14' undeclared (first use in this function)
../common/Pcore.c:513: error: 'REG_R13' undeclared (first use in this function)
../common/Pcore.c:514: error: 'REG_R12' undeclared (first use in this function)
../common/Pcore.c:515: error: 'REG_R11' undeclared (first use in this function)
../common/Pcore.c:516: error: 'REG_R10' undeclared (first use in this function)
../common/Pcore.c:517: error: 'REG_R9' undeclared (first use in this function)
../common/Pcore.c:518: error: 'REG_R8' undeclared (first use in this function)
../common/Pcore.c:520: error: 'REG_RDI' undeclared (first use in this function)
../common/Pcore.c:521: error: 'REG_RSI' undeclared (first use in this function)
../common/Pcore.c:522: error: 'REG_RBP' undeclared (first use in this function)
../common/Pcore.c:523: error: 'REG_RBX' undeclared (first use in this function)
../common/Pcore.c:524: error: 'REG_RDX' undeclared (first use in this function)
../common/Pcore.c:525: error: 'REG_RCX' undeclared (first use in this function)
../common/Pcore.c:526: error: 'REG_RAX' undeclared (first use in this function)
../common/Pcore.c:528: error: 'REG_RIP' undeclared (first use in this function)
../common/Pcore.c:529: error: 'REG_CS' undeclared (first use in this function)
../common/Pcore.c:530: error: 'REG_RSP' undeclared (first use in this function)
../common/Pcore.c:531: error: 'REG_FS' undeclared (first use in this function)
../common/Pcore.c:532: error: 'REG_SS' undeclared (first use in this function)
../common/Pcore.c:533: error: 'REG_GS' undeclared (first use in this function)
../common/Pcore.c:534: error: 'REG_ES' undeclared (first use in this function)
../common/Pcore.c:535: error: 'REG_DS' undeclared (first use in this function)
../common/Pcore.c:537: error: 'REG_GSBASE' undeclared (first use in this functio
n)
../common/Pcore.c:538: error: 'REG_FSBASE' undeclared (first use in this functio
n)
../common/Pcore.c:565: error: 'EBX' undeclared (first use in this function)
../common/Pcore.c:566: error: 'ECX' undeclared (first use in this function)
../common/Pcore.c:567: error: 'EDX' undeclared (first use in this function)
../common/Pcore.c:568: error: 'ESI' undeclared (first use in this function)
../common/Pcore.c:569: error: 'EDI' undeclared (first use in this function)
../common/Pcore.c:570: error: 'EBP' undeclared (first use in this function)
../common/Pcore.c:571: error: 'EAX' undeclared (first use in this function)
../common/Pcore.c:572: error: 'EIP' undeclared (first use in this function)
../common/Pcore.c:573: error: 'UESP' undeclared (first use in this function)
../common/Pcore.c:575: error: 'DS' undeclared (first use in this function)
../common/Pcore.c:576: error: 'ES' undeclared (first use in this function)
../common/Pcore.c:577: error: 'FS' undeclared (first use in this function)
../common/Pcore.c:578: error: 'GS' undeclared (first use in this function)
../common/Pcore.c:579: error: 'CS' undeclared (first use in this function)
../common/Pcore.c:580: error: 'SS' undeclared (first use in this function)
../common/Pcore.c:582: error: 'EFL' undeclared (first use in this function)
dmake: Warning: Command failed for target `pics/Pcore.o'


Files

pcore.diff (2.32 KB) pcore.diff Gary Mills, 2014-12-21 03:40 PM

Related issues

Related to illumos gate - Feature #5234: libproc could understand Linux core filesClosedRobert Mustacchi2014-10-16

Actions
Actions #1

Updated by Gary Mills over 6 years ago

The solution here is more conditional code to eliminate Linux core file processing on the SPARC platform. The patch file I used is attached. It allows the build to proceed, but is not tested because I had no way to boot the illumos build on this platform.

Actions #2

Updated by Gary Mills over 6 years ago

  • Assignee set to Gary Mills
  • % Done changed from 30 to 60

I'll take this one.

Actions #3

Updated by Electric Monk over 6 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 60 to 100

git commit 6ca738233e59efaafdd9083077d19ca19802b6ba

commit  6ca738233e59efaafdd9083077d19ca19802b6ba
Author: Gary Mills <gary_mills@fastmail.fm>
Date:   2015-01-12T17:58:52.000Z

    5383 5234 breaks build on sparc
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF