Project

General

Profile

Bug #5393

spurious failures from dsl_dataset_hold_obj()

Added by Matthew Ahrens almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-12-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

The large block code introduced a regression which causes dsl_dataset_hold_obj() to fail if the dataset is zapified but does not have large blocks.

The proposed patch changes the code to use similar construct that DS_FIELD_BOOKMARK_NAMES used to avoid overwriting 'err'.


Files

dsl_dataset.patch (512 Bytes) dsl_dataset.patch Proposed patch Xin Li, 2014-12-05 04:48 AM
dsl_dataset-v2.patch (696 Bytes) dsl_dataset-v2.patch Proposed patch (version 2) Xin Li, 2014-12-05 05:41 PM

History

#1

Updated by Xin Li almost 5 years ago

Proposed patch

#2

Updated by Xin Li almost 5 years ago

  • Status changed from New to In Progress
#3

Updated by Xin Li almost 5 years ago

After reading the code another time, I'd like to propose the attached change instead.

#5

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e1f3c208abda53769a6531bb1141618555273460

commit  e1f3c208abda53769a6531bb1141618555273460
Author: Justin T. Gibbs <justing@spectralogic.com>
Date:   2015-04-15T01:03:34.000Z

    5393 spurious failures from dsl_dataset_hold_obj()
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Will Andrews <willa@spectralogic.com>
    Reviewed by: Prakash Surya <prakash.surya@delphix.com>
    Reviewed by: Steven Hartland <killing@multiplay.co.uk>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF