Actions
Bug #5393
closed
spurious failures from dsl_dataset_hold_obj()
Start date:
2014-12-05
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
The large block code introduced a regression which causes dsl_dataset_hold_obj() to fail if the dataset is zapified but does not have large blocks.
The proposed patch changes the code to use similar construct that DS_FIELD_BOOKMARK_NAMES used to avoid overwriting 'err'.
Files
Updated by Xin Li over 8 years ago
- File dsl_dataset.patch dsl_dataset.patch added
- % Done changed from 0 to 90
Proposed patch
Updated by Xin Li over 8 years ago
- File dsl_dataset-v2.patch dsl_dataset-v2.patch added
After reading the code another time, I'd like to propose the attached change instead.
Updated by Xin Li over 8 years ago
Review request: https://reviews.csiden.org/r/143/
Updated by Electric Monk about 8 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit e1f3c208abda53769a6531bb1141618555273460
commit e1f3c208abda53769a6531bb1141618555273460
Author: Justin T. Gibbs <justing@spectralogic.com>
Date: 2015-04-15T01:03:34.000Z
5393 spurious failures from dsl_dataset_hold_obj()
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Will Andrews <willa@spectralogic.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Steven Hartland <killing@multiplay.co.uk>
Approved by: Dan McDonald <danmcd@omniti.com>
Actions