Project

General

Profile

Actions
Copy link

Bug #5438

closed

zfs_blkptr_verify should continue after zfs_panic_recover

Added by Xin Li over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2014-12-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

This is reported by FreeBSD Coverity Scan, CID 1258589 should be referenced.

In ZFS many places we use zfs_panic_recover, where the code is able to continue after hitting the asserted condition, if system administrator requests so.

The new zfs_blkptr_verify should take this into account and do not do e.g. access vd->vdev_ops after checking if vd is NULL.

Actions
Copy link
 #2

Updated by Electric Monk about 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 5897eb49ccde82d19214b71984f57935e7e313d1

commit  5897eb49ccde82d19214b71984f57935e7e313d1
Author: Justin Gibbs <gibbs@scsiguy.com>
Date:   2015-05-27T14:09:18.000Z

    5438 zfs_blkptr_verify should continue after zfs_panic_recover
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: George Wilson <george@delphix.com>
    Reviewed by: Xin LI <delphij@freebsd.org>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF