Project

General

Profile

Actions
Copy link

Bug #5510

closed

elfdump doesn't print the member header before pr_reg

Added by Rich Lowe over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Rich Lowe
Category:
cmd - userland programs
Start date:
2015-01-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

There are a couple of missing variable initializations in elfdump. The most important one is that dump_prgregset passes stack junk when calling indent_enter, and thus does not (necessarily) print the member header before printing the member data.

The other is that that we try to decode pr_what even if we haven't been able to read pr_why. This is very unlikely to happen in practice, but we should fix it anyway.

(these aren't the only initialization problems in elfdump, but they are the only ones in corenote.c, which is where I was having to look to debug the missing member name).

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3f3aaf4e95972f6d6393cbff0a4652f4ee2c0dbf

commit  3f3aaf4e95972f6d6393cbff0a4652f4ee2c0dbf
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2015-01-09T18:28:14.000Z

    5510 elfdump doesn't print the member header before pr_reg
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF