Project

General

Profile

Bug #5528

devid_str_free() should be used for devid_get_minor_name() too

Added by Marcel Telka almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
manpage - manual pages
Start date:
2015-01-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

In the devid_get(3devid) man page there is this:

       The devid_get_minor_name() function returns the minor name, in
       retminor_name, for the device associated with the open file descriptor
       fd. This name is specific to the particular minor number, but is
       "instance number" specific. The caller of this function must free the
       memory allocated for the returned retminor_name string using
       devid_str_free().

But the description for devid_str_free() does not mention devid_get_minor_name():

       The devid_str_free() function frees the character string returned by
       devid_str_encode() and the retminor_name argument returned by
       devid_str_decode().

We should fix that.

History

#1

Updated by Marcel Telka almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Marcel Telka
#2

Updated by Marcel Telka almost 5 years ago

  • Status changed from In Progress to Pending RTI
#3

Updated by Electric Monk almost 5 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit faf5add516ff7b15d67af766e32716c04c75716d

commit  faf5add516ff7b15d67af766e32716c04c75716d
Author: Marcel Telka <marcel.telka@nexenta.com>
Date:   2015-02-09T23:38:43.000Z

    5528 devid_str_free() should be used for devid_get_minor_name() too
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF