Actions
Bug #5529
open
missed zcmd_free_nvlists() after zcmd_write_src_nvlist() in libzfs
Start date:
2015-01-12
Due date:
% Done:
0%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
Another example:
http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libzfs/common/libzfs_dataset.c
line 4130.Line 4141 also misses zcmd_free_nvlists
<http://src.illumos.org/source/s?defs=zcmd_free_nvlists&project=illumos-gate>()
[....] The zfs_smb_acl_mgmt() leaks some memory and we should add the
zcmd_free_nvlists(&zc) call somewhere before the final return at line 4143. In
addition, we could also leak the nvlist at lines 4123, 4128, and 4138.
Updated by Marcel Telka over 8 years ago
Also, the return value at line 4110 is wrong. We should definitely return something different than NULL here.
Actions