Actions
Bug #5564
closedarcstat does not work after 5497
Status:
Closed
Priority:
High
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2015-01-28
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
The integration of 5497 appears to have introduced a regression in arcstat in that one of the kstats that it uses is no longer available which causes the program to fail. In this case it's failing because the arcstat_recycle_miss kstat has been removed.
[root@headnode (coal) ~]# arcstat 1 time read miss miss% dmis dm% pmis pm% mmis mm% arcsz c Use of uninitialized value in division (/) at /usr/bin/arcstat line 329. 14:29:43 0 0 0 0 0 0 0 0 0 606M 606M Use of uninitialized value in division (/) at /usr/bin/arcstat line 329. 14:29:44 51 22 43 22 43 0 0 1 100 606M 606M Use of uninitialized value in division (/) at /usr/bin/arcstat line 329. 14:29:45 14 11 78 11 78 0 0 0 0 606M 606M
On systems before that change:
[root@00-0c-29-37-80-28 ~]# kstat -m zfs -p | grep recycle zfs:0:arcstats:recycle_miss 261672
Post the change:
[root@headnode (coal) ~]# kstat -m zfs -p | grep recycle [root@headnode (coal) ~]#
This was originally reported to me as https://github.com/joyent/smartos-live/issues/391.
Updated by Prakash Surya over 8 years ago
I've pushed a simple fix for this here: https://reviews.csiden.org/r/164/
Updated by Electric Monk over 8 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 78d7e9613776b02098bc0b12fc9b9652b788b605
commit 78d7e9613776b02098bc0b12fc9b9652b788b605 Author: Prakash Surya <prakash.surya@delphix.com> Date: 2015-04-06T17:27:33.000Z 5564 arcstat does not work after 5497 Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george@delphix.com> Reviewed by: Alek Pinchuk <alek.pinchuk@nexenta.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Approved by: Garrett D'Amore <garrett@damore.org>
Actions