Project

General

Profile

Actions
Copy link

Bug #5571

closed

Provide 64-bit python modules

Added by Alex Reece over 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
zfs - Zettabyte File System
Start date:
2015-01-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We do not provide a 64 bit version of the solaris.misc python library:

delphix@oi-151:~$ /usr/bin/amd64/python
Python 2.6.4 (r264:75706, Nov 16 2013, 20:48:20) [C] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> import solaris.misc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named misc
>>>

This is unfortunate on OmniOS, where python is 64 bit by default and pyzfs no longer works:

$ /usr/lib/zfs/pyzfs.py
Traceback (most recent call last):
  File "/usr/lib/zfs/pyzfs.py", line 34, in <module>
    import zfs.util
  File "/usr/lib/python2.6/vendor-packages/zfs/util.py", line 31, in <module>
    import solaris.misc
ImportError: No module named misc
Actions
Copy link
 #1

Updated by Andy Fiddaman over 3 years ago

  • Assignee set to Andy Fiddaman
Actions
Copy link
 #2

Updated by Andy Fiddaman over 3 years ago

  • Subject changed from no 64 bit solaris.misc python module to No 64-bit python modules
  • % Done changed from 0 to 70
  • Tags deleted (needs-triage)

Updating this to handle all missing 64-bit python modules

Actions
Copy link
 #3

Updated by Andy Fiddaman over 3 years ago

  • Subject changed from No 64-bit python modules to Provide 64-bit python modules
Actions
Copy link
 #4

Updated by Andy Fiddaman over 3 years ago

  • Status changed from New to Pending RTI
  • % Done changed from 70 to 100
Actions
Copy link
 #5

Updated by Andy Fiddaman over 3 years ago

Testing notes:

#!/bin/sh

py2test()
{
        echo "************* $1" 

        echo '              32-bit'
        ISALIST=i386 python2 -c "$2" 
        echo '              64-bit'
        ISALIST=amd64 python2 -c "$2" 
}

zfsmods="allow dataset groupspace holds table unallow userspace util" 

echo "***" 
echo "*** python2" 
echo "***" 
python2 --version

py2test libbe_py 'import libbe_py; print len(libbe_py.beList())'
py2test solaris.misc 'import solaris.misc; print solaris.misc.isglobalzone()'
for z in $zfsmods; do
        py2test zfs.$z "import zfs.$z" 
done
ISALIST=i386 pfexec python2 /usr/lib/zfs/pyzfs.py userspace rpool
ISALIST=amd64 pfexec python2 /usr/lib/zfs/pyzfs.py userspace rpool

Output:

bloody% ./pytest
***
*** python2
***
Python 2.7.15
************* libbe_py
              32-bit
2
              64-bit
2
************* solaris.misc
              32-bit
1
              64-bit
1
************* zfs.allow
              32-bit
              64-bit
************* zfs.dataset
              32-bit
              64-bit
************* zfs.groupspace
              32-bit
              64-bit
************* zfs.holds
              32-bit
              64-bit
************* zfs.table
              32-bit
              64-bit
************* zfs.unallow
              32-bit
              64-bit
************* zfs.userspace
              32-bit
              64-bit
************* zfs.util
              32-bit
              64-bit
TYPE        NAME  USED  QUOTA
POSIX User  root   10K   none
TYPE        NAME  USED  QUOTA
POSIX User  root   10K   none
Actions
Copy link
 #6

Updated by Electric Monk over 3 years ago

  • Status changed from Pending RTI to Closed

git commit e8921a52c53ee69f7b65f054d9b2e886139daa59

commit  e8921a52c53ee69f7b65f054d9b2e886139daa59
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2018-10-24T19:27:58.000Z

    9894 Deliver python3 modules
    9904 Split python modules out into separate packages
    5571 Provide 64-bit python modules
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF