Project

General

Profile

Bug #5575

sockmod_pfp needs larger statistics counters

Added by Robert Mustacchi almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
networking
Start date:
2015-01-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

sockmod_pfp uses uint16 counters to record data for getsockopt(PACKET_STATISTICS).
Longer traces and/or high packet rates could quickly cause roll-over in those counters. It would be advantageous to use 32bit or larger counters.

Here, we opt to retain the old PACKET_STATISTICS ioctl value and instead change PACKET_STATISTICS to a new form which indicates that is has a newer buffer which is large enough to handle the new structure size and expects the new structure layout.

#1

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed

git commit 336069c20319c172c4ff9d87d67e8f6301c98a5d

commit  336069c20319c172c4ff9d87d67e8f6301c98a5d
Author: Patrick Mooney <patrick.f.mooney@gmail.com>
Date:   2015-02-14T18:56:48.000Z

    5573 sockmod_pfp improperly handles SO_RCVBUF
    5574 sockmod_pfp unable to locate ifindex for bind
    5575 sockmod_pfp needs larger statistics counters
    5576 sockmod_pfp improperly handles SIOCGSTAMP
    5577 sockmod_pfp should limit bpf program size
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF