sockmod_pfp needs larger statistics counters
sockmod_pfp uses uint16 counters to record data for getsockopt(PACKET_STATISTICS).
Longer traces and/or high packet rates could quickly cause roll-over in those counters. It would be advantageous to use 32bit or larger counters.
Here, we opt to retain the old PACKET_STATISTICS ioctl value and instead change PACKET_STATISTICS to a new form which indicates that is has a newer buffer which is large enough to handle the new structure size and expects the new structure layout.
Updated by Electric Monk over 6 years ago
- Status changed from New to Closed
commit 336069c20319c172c4ff9d87d67e8f6301c98a5d Author: Patrick Mooney <email@example.com> Date: 2015-02-14T18:56:48.000Z 5573 sockmod_pfp improperly handles SO_RCVBUF 5574 sockmod_pfp unable to locate ifindex for bind 5575 sockmod_pfp needs larger statistics counters 5576 sockmod_pfp improperly handles SIOCGSTAMP 5577 sockmod_pfp should limit bpf program size Reviewed by: Jerry Jelinek <firstname.lastname@example.org> Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Richard Lowe <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>