Project

General

Profile

Bug #5576

sockmod_pfp improperly handles SIOCGSTAMP

Added by Robert Mustacchi almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
networking
Start date:
2015-01-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When making an SIOCGSTAMP ioctl to a PF_PACKET socket, sockmod_pfp commits two wrongs:

1. It attempts to do an ifindex lookup unnecessarily (resulting in an error when it fails on the lack of input)

2. A timeval32 struct is always used for output, regardless of if the platform is 64bit.

#1

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed

git commit 336069c20319c172c4ff9d87d67e8f6301c98a5d

commit  336069c20319c172c4ff9d87d67e8f6301c98a5d
Author: Patrick Mooney <patrick.f.mooney@gmail.com>
Date:   2015-02-14T18:56:48.000Z

    5573 sockmod_pfp improperly handles SO_RCVBUF
    5574 sockmod_pfp unable to locate ifindex for bind
    5575 sockmod_pfp needs larger statistics counters
    5576 sockmod_pfp improperly handles SIOCGSTAMP
    5577 sockmod_pfp should limit bpf program size
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF