sockmod_pfp improperly handles SIOCGSTAMP
When making an SIOCGSTAMP ioctl to a PF_PACKET socket, sockmod_pfp commits two wrongs:
1. It attempts to do an ifindex lookup unnecessarily (resulting in an error when it fails on the lack of input)
2. A timeval32 struct is always used for output, regardless of if the platform is 64bit.
Updated by Electric Monk about 7 years ago
- Status changed from New to Closed
commit 336069c20319c172c4ff9d87d67e8f6301c98a5d Author: Patrick Mooney <firstname.lastname@example.org> Date: 2015-02-14T18:56:48.000Z 5573 sockmod_pfp improperly handles SO_RCVBUF 5574 sockmod_pfp unable to locate ifindex for bind 5575 sockmod_pfp needs larger statistics counters 5576 sockmod_pfp improperly handles SIOCGSTAMP 5577 sockmod_pfp should limit bpf program size Reviewed by: Jerry Jelinek <email@example.com> Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Richard Lowe <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>