Project

General

Profile

Actions
Copy link

Bug #5589

closed

improper use of NULL in tools/ctf

Added by Richard PALO over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-02-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

There are a few improper uses of NULL in tools/ctf.

The attached patch fixes using NULL where:
- an integer type is expected either as a return value or to compare
with functions returning integers (like strchr, which returns an index not an address)
- the NULL character is not an address but a value (0 or rather '\\0')

Files

0001-5589-improper-use-of-NULL-in-tools-ctf.patch (3.16 KB) 0001-5589-improper-use-of-NULL-in-tools-ctf.patch Richard PALO, 2015-02-04 08:33 AM
Actions
Copy link
 #2

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit ad0b1ea5d69a45fe23c434277599e315f29a5fca

commit  ad0b1ea5d69a45fe23c434277599e315f29a5fca
Author: Richard PALO <richard@NetBSD.org>
Date:   2015-02-08T02:40:56.000Z

    5589 improper use of NULL in tools/ctf
    Reviewed by: David Höppner <0xffea@gmail.com>
    Reviewed by: Josef "Jeff" Sipek <jeffpc@josefsipek.net>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF