Project

General

Profile

Bug #5598

cstyle issues with new libm

Added by Richard PALO over 4 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-02-07
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

This is a placeholder to complete the libm integration,
git pbchk in the gate (or directly cstyle) finds an extremely large number of issues:

richard@omnis:/home/richard/src/illumos-gate/usr/src$ find lib/libm -name '*.[ch]' -exec cstyle {} \\; |wc -l
    4253
richard@omnis:/home/richard/src/illumos-gate/usr/src$ find lib/libm -name '*.[ch]' -exec cstyle {} \\; |cut -d':' -f3 |sort -u
 #define followed by space instead of tab
 block comment not indented by tabs
 comma or semicolon followed by non-blank
 comma or semicolon preceded by blank
 comment preceded by non-blank
 continuation line not indented by 4 spaces
 don't use boolean ! with comparison functions
 else and right brace should be on same line
 extra space between function name and left paren
 improper block comment
 improper block comment close
 improper boolean continuation
 improper first line of block comment
 indent by spaces instead of tabs
 last line in file is blank
 left brace starting a line
 line > 80 characters
 missing blank after open comment
 missing blank before close comment
 missing space after (void) cast
 missing space around assignment operator
 missing space around relational operator
 missing space before left brace
 missing space between keyword and paren
 missing space between type name and *
 more than one keyword on line
 return type of function not on separate line
 space or tab at end of line
 spaces between tabs
 spaces instead of tabs
 tabs between spaces
 unparenthesized return expression
 unterminated single line comment
 whitespace before right paren


Related issues

Has duplicate illumos gate - Bug #11210: libm should be cstyle(1ONBLD) cleanIn Progress

Actions

History

#1

Updated by Rich Lowe 5 months ago

  • Has duplicate Bug #11210: libm should be cstyle(1ONBLD) clean added
#2

Updated by Rich Lowe 5 months ago

  • Status changed from New to Closed

Also available in: Atom PDF