Project

General

Profile

Bug #5600

type inconsistent with format introduced in ctf.c

Added by Richard PALO over 5 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-02-07
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

This commit:

commit 1c4f4ba644d8782956721a39baaa3a53ebc34570
Author: John Levon <john.levon@sun.com>
Date:   Wed Jul 29 14:36:30 2009 -0700

    6854065 CTF tools should error out given 1024+-member structures

introduced an issue missing args in the format definition at line 407:

         case FUNCTION:
 404                 i = tp->t_fndef->fn_nargs + tp->t_fndef->fn_vargs;
 405 
 406                 if (i > CTF_MAX_VLEN) {
 407                         terminate("function %s has too many args: %d > %d\\n     ",
 408                             i, CTF_MAX_VLEN);
 409                 }

This should perhaps be (like in UNION):

        case FUNCTION:
                 i = tp->t_fndef->fn_nargs + tp->t_fndef->fn_vargs;

                 if (i > CTF_MAX_VLEN) {
                         terminate("function %s has too many args: %d > %d\\n     ",
                             tdesc_name(tp), i, CTF_MAX_VLEN);
                 }

#1

Updated by Robert Mustacchi about 1 month ago

  • Status changed from New to Closed

As of #11657 the file this refers to which used to be usr/src/tools/ctf/cvt/ctf.c was removed from the source tree.

Also available in: Atom PDF