Project

General

Profile

Bug #5610

zfs clone from different source and target pools produces coredump

Added by Alexander Eremin over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2015-02-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

zfs should exit with "source and target pools differ" but produces coredump in case of different pools:

#zfs clone rpool/code@test data/test
internal error: Invalid argument
Abort (core dumped)

Related issues

Has duplicate illumos gate - Bug #5824: zfs_ioc_clone() return EINVAL where EXDEV is expectedRejected2015-04-10

Actions

History

#1

Updated by Alexander Eremin over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Alexander Eremin
  • % Done changed from 0 to 50
#2

Updated by Alexander Eremin over 4 years ago

  • % Done changed from 50 to 80
#3

Updated by Andriy Gapon over 4 years ago

Based on analysis in #5824 I'd suggest to also remove those two checks for differing pools in dmu_objset_clone_check() that can never be true.

#4

Updated by Alexander Eremin over 4 years ago

This makes sense, I'm going to re-test.

#5

Updated by Dan McDonald over 4 years ago

Please see the duplicate bug #5824 for a detailed analysis.

#6

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

git commit 03b1c2971d24a9cd2c073d634f7e074fbd14e984

commit  03b1c2971d24a9cd2c073d634f7e074fbd14e984
Author: Alexander Eremin <a.eremin@nexenta.com>
Date:   2015-04-15T13:59:40.000Z

    5610 zfs clone from different source and target pools produces coredump
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF