ZFS bootfs tests need some work
We noticed that the ZFS test bootfs_002_neg started to fail after the Grub EFI changes (5560, 5561, and 5664) integrated.
Looking closely at the bootfs tests, two things become obvious:
- bootfs_007_neg is the test that verifies that no bootfs property can be set on pools that use EFI-labeled disks. With the integration of NEX-3025 this test is actually wrong. It needs to be reversed and renamed.
- bootfs_002_neg creates a pool on a EFI-labeled disk (by specifying a full disk device like c4t0d0). Before the integration of NEX-3025 this caused both test commands for the bootfs property to fail, simply because bootfs properties on EFI-labeled disks weren't allowed. In other words, the test didn't test what it claimed to test.
Changing bootfs_002_neg to use a pool on a file similar to what bootfs_001_pos does will at least make the test really test what it claims to test. Then it will behave the same on a system with the EFI changes as on a system without the EFI changes: it will fail because snapshots as bootfs have been allowed since 2008 already. So this needs to be changed, too.
Updated by Electric Monk about 7 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit c029eafbb040b81649027c5ae5a38e92d214461b Author: Hans Rosenfeld <email@example.com> Date: 2015-03-10T19:52:35.000Z 5684 ZFS bootfs tests need some work Reviewed by: Jean McCormack <firstname.lastname@example.org> Reviewed by: Josef 'Jeff' Sipek <email@example.com> Reviewed by: John Kennedy <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>