Project

General

Profile

Bug #5686

lint warnings in uts/sparc/stfm_sbd after 5056

Added by Gordon Ross over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2015-03-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

After #5056 was pushed I get tons of lint building uts/sparc/stfm_sbd like:

"/tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c", line 1070: warning: name multiply defined: stmf_add_ent_to_map in /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1070) and /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1070) (E_NAME_MULTIPLY_DEF2)
"/tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c", line 1102: warning: name multiply defined: stmf_remove_ent_from_map in /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1102) and /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1102) (E_NAME_MULTIPLY_DEF2)
"/tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c", line 1139: warning: name multiply defined: stmf_get_next_free_lun in /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1139) and /tank/ws/gwr/illumos-il5526b/usr/src/uts/common/io/comstar/stmf/lun_map.c(1139) (E_NAME_MULTIPLY_DEF2)

(every stmf file gets such complaints)

#1

Updated by Gordon Ross over 5 years ago

This commit introduced an unexpected change:

commit bc9014e6a81272073b9854d9f65dd59e18d18c35
Author: Justin Gibbs <justing@spectralogic.com>
Date:   Mon Jan 5 19:27:09 2015 -0500

    5056 ZFS deadlock on db_mtx and dn_holds
    Reviewed by: Will Andrews <willa@spectralogic.com>
    Reviewed by: Matt Ahrens <mahrens@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Here's the change. Note that it's adding user-level libraries to a kernel link line

diff --git a/usr/src/uts/sparc/stmf_sbd/Makefile b/usr/src/uts/sparc/stmf_sbd/Makefile
index a57ccaf..9480a44 100644
--- a/usr/src/uts/sparc/stmf_sbd/Makefile
+++ b/usr/src/uts/sparc/stmf_sbd/Makefile
@@ -57,6 +57,7 @@ INSTALL_TARGET    = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
 #
 MODSTUBS_DIR     = $(OBJS_DIR)
 LDFLAGS        += -dy -Ndrv/stmf -Nfs/zfs
+LINTTAGS    += -L$(LINT_LIB_DIR) -lstmf -lzfs

 INC_PATH    += -I$(UTSBASE)/common/fs/zfs

Reverting the change in this file makes that lint noise go away.

#2

Updated by Gordon Ross over 5 years ago

BTW, that change came in due to an oversight when some of the original changes for 5056 were backed out during code review.
This change should also have been dropped when the other changes were dropped.

#3

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 356f579978bd7347c891f2a7b1e9671086f183ae

commit  356f579978bd7347c891f2a7b1e9671086f183ae
Author: Gordon Ross <gwr@nexenta.com>
Date:   2015-03-06T21:30:59.000Z

    5686 lint warnings in uts/sparc/stfm_sbd after 5056
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF