Project

General

Profile

Actions

Bug #5696

closed

::refcount -r does not display info about removal of holds

Added by Matthew Ahrens over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2015-03-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

When reference_tracking_enable is set, zfs keeps track of a certain number of recent holds and when they were removed. These should be printed by ::recount -r, but are not.

example of what it should look like:

ffffff01dcd00850::refcount -r

refcount_t at ffffff01dcd00850 has 0 current holds, 1 recently released holds
released holds:
removed reference with tag ffffff01dcd06028, held at:
ffffff01dcd05140 is allocated from reference_cache:
ADDR BUFADDR TIMESTAMP THREAD
CACHE LASTLOG CONTENTS
ffffff01dccc6da8 ffffff01dcd05140 197d7c3c930 ffffff01dcd02b60
ffffff01d83f9588 ffffff01ce0a5bc0 0
kmem_cache_alloc_debug+0x2e8
kmem_cache_alloc+0x2db
refcount_add_many+0x82
refcount_add+0x1d
arc_buf_alloc+0x123
arc_read+0x17b
dbuf_read_impl+0x241
dbuf_read+0xf9
dmu_buf_hold+0x78
zap_get_leaf_byblk+0x80
zap_deref_leaf+0x106
fzap_cursor_retrieve+0x12c
zap_cursor_retrieve+0x6f
sa_setup+0x38a
zfsvfs_create+0x23b
removed at:
ffffff01dccffcc0 is allocated from reference_history_cache:
ADDR BUFADDR TIMESTAMP THREAD
CACHE LASTLOG CONTENTS
ffffff01dccd7888 ffffff01dccffcc0 197d7d44bb7 ffffff01dcd02b60
ffffff01d83f9848 ffffff01ce0a8140 0
kmem_cache_alloc_debug+0x2e8
kmem_cache_alloc+0x2db
refcount_remove_many+0xb6
refcount_remove+0x1d
remove_reference+0x91
arc_buf_remove_ref+0x10d
dbuf_rele_and_unlock+0x157
dbuf_rele+0x30
dmu_buf_rele+0x15
zap_put_leaf+0x23
zap_cursor_fini+0x57
sa_setup+0x418
zfsvfs_create+0x23b
zfs_domount+0x40
zfs_mount+0x24f

Actions #1

Updated by Electric Monk over 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 421ff02063e68ff03db7d5169c62e3f94927000f

commit  421ff02063e68ff03db7d5169c62e3f94927000f
Author: Prakash Surya <prakash.surya@delphix.com>
Date:   2015-03-24T16:47:20.000Z

    5696 ::refcount -r does not display info about removal of holds
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: George Wilson <george@delphix.com>
    Reviewed by: Paul Dagnelie <paul.dagnelie@delphix.com>
    Reviewed by: Basil Crow <basil.crow@delphix.com>
    Reviewed by: Bayard Bell <buffer.g.overflow@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions

Also available in: Atom PDF