Project

General

Profile

Actions
Copy link

Bug #5710

closed

iswblank_l missing from headers

Added by C B over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Garrett D'Amore
Category:
locale - data and messages
Start date:
2015-03-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

This commit in libc++ exposed an issue that iswblank_l isn't in the headers
https://github.com/llvm-mirror/libcxx/commit/6fb33ea8fb10be941c1b66d7054a67a9356a893d

upstream worked around it with this ugly hack
#if !defined(sun)
if (iswblank_l(ch, __l))
*vec |= blank;
#endif

The actual build error I got was

/root/libcxx/src/locale.cpp:1315:17:
error: use of undeclared identifier 'iswblank_l'; did you mean
'isblank_l'?
if (iswblank_l(ch, __l))
^~~~~~~~
isblank_l
/usr/include/ctype.h:100:12: note: 'isblank_l' declared here
extern int isblank_l(int, locale_t);
^

Actions
Copy link
 #1

Updated by Garrett D'Amore over 8 years ago 

--- a/usr/src/head/wctype.h
+++ b/usr/src/head/wctype.h
@@ -24,7 +24,7 @@
 /*     definitions for international functions */

 /*
- * Copyright 2014 Garrett D'Amore <garrett@damore.org>
+ * Copyright 2015 Garrett D'Amore <garrett@damore.org>
  *
  * Copyright 2003 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
@@ -141,6 +141,7 @@ extern wint_t towctrans_l(wint_t, wctrans_t, locale_t);
 extern int iswctype_l(wint_t, wctype_t, locale_t);
 extern int iswalnum_l(wint_t, locale_t);
 extern int iswalpha_l(wint_t, locale_t);
+extern int iswblank_l(wint_t, locale_t);
 extern int iswcntrl_l(wint_t, locale_t);
 extern int iswdigit_l(wint_t, locale_t);
 extern int iswgraph_l(wint_t, locale_t);
Actions
Copy link
 #2

Updated by Garrett D'Amore over 8 years ago

  • Category set to locale - data and messages
  • % Done changed from 0 to 90
  • Difficulty changed from Medium to Bite-size

So it turns out I have to fix this in -core too. Apparently I just forgot to add this symbol to the header. It is in the link maps, and the symbol is exposed, I believe.

Actions
Copy link
 #3

Updated by Electric Monk over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 61a52ead5b18fada129835d3958519853b5e74ba

commit  61a52ead5b18fada129835d3958519853b5e74ba
Author: Garrett D'Amore <garrett@hipster.(none)>
Date:   2015-04-05T19:48:05.000Z

    5710 iswblank_l missing from headers
    Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF