Project

General

Profile

Actions
Copy link

Bug #5732

closed

nightly.sh should use check-paths.out to be useful for .gitignore

Added by Richard PALO about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-03-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

.gitignore has the rule 

/usr/src/check-*.out

this patch avoids some `git status` noise:

diff --git a/usr/src/tools/scripts/nightly.sh b/usr/src/tools/scripts/nightly.sh
index 77d23a7..610cfc3 100644
--- a/usr/src/tools/scripts/nightly.sh
+++ b/usr/src/tools/scripts/nightly.sh
@@ -2156,9 +2156,9 @@ if [ "$CHECK_PATHS" = y -a "$N_FLAG" != y ]; then
                >>$mail_msg_file
        arg=-b
        [ "$build_ok" = y ] && arg=
-       checkpaths $arg $checkroot > $SRC/checkpaths.out 2>&1
-       if [[ -s $SRC/checkpaths.out ]]; then
-               tee -a $LOGFILE < $SRC/checkpaths.out >> $mail_msg_file
+       checkpaths $arg $checkroot > $SRC/check-paths.out 2>&1
+       if [[ -s $SRC/check-paths.out ]]; then
+               tee -a $LOGFILE < $SRC/check-paths.out >> $mail_msg_file
                build_extras_ok=n
        fi
 fi
Actions
Copy link
 #1

Updated by Richard PALO about 8 years ago

To be clear, prior to this patch, the output of checkpaths went to $SRC/checkpaths.out.

After a `dmake clobber`, git status would indicated an 'untracked' file in /usr/src/checkpaths.out

Since .gitignore has a rule to ignore files of the template '/usr/src/check-*.out', this patch
enables now by default that this file be silently ignored as demonstrated in https://www.illumos.org/rb/r/5

Actions
Copy link
 #2

Updated by Electric Monk about 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e2c8add4a6cefe2fe3a4b140f54561823d493bcc

commit  e2c8add4a6cefe2fe3a4b140f54561823d493bcc
Author: Richard PALO <richard@NetBSD.org>
Date:   2015-03-21T19:35:01.000Z

    5732 nightly.sh should use check-paths.out to be useful for .gitignore
    Reviewed by: Josef 'Jeff' Sipek<jeffpc@josefsipek.net>
    Reviewed by: Toomas Soome<tsoome@me.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF