Project

General

Profile

Actions

Bug #5763

closed

missing va_end() on return from __fini_daemon_priv()

Added by Serghei Samsi over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
lib - userland libraries
Start date:
2015-03-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Line 579, file /illumos-gate/usr/src/lib/libc/port/gen/privlib.c:

571 priv_set_t *nset;
572 va_list pa;
573
574 va_start(pa, priv);
575
576 if (priv != NULL) {
577 nset = priv_vlist(pa);
578 if (nset == NULL)
579 return;
580
581 (void) priv_addset(nset, priv);
582 (void) setppriv(PRIV_OFF, permitted, nset);
583 priv_freeset(nset);
584 }
585
586 va_end(pa);

Actions #1

Updated by Gary Mills about 6 years ago

I'll handle this one. The code changes are about 90% complete. I'm in the testing phase now.

Actions #2

Updated by Electric Monk about 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 75598e109dfb54c4a0364e1544f5aff609d2c978

commit  75598e109dfb54c4a0364e1544f5aff609d2c978
Author: Gary Mills <gary_mills@fastmail.fm>
Date:   2015-05-01T01:08:41.000Z

    5763 missing va_end() on return from __fini_daemon_priv()
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF