Project

General

Profile

Bug #5786

Fast reboot broken on EFI formatted drives

Added by Oscar del Rio over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2015-04-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Fast reboot fails with the following error on EFI formatted drives:

reboot: Failed to process GRUB menu entry for fast reboot.
Invalid format for findroot
reboot: Falling back to regular reboot.

The GRUB findroot line is:

  1. grep findroot /rpool/boot/grub/menu.lst
    findroot (pool_rpool,0)

History

#1

Updated by Oscar del Rio over 4 years ago

The parsing error might be in findroot()
usr/src/lib/libgrubmgmt/common/libgrub_cmd.c

https://github.com/illumos/illumos-gate/commit/1a902ef8628b0dffd6df5442354ab59bb8530962#diff-c92ce085bb90240bf69fcf9ecfbab5ad

when there is no third argument, e.g. "findroot (pool_rpool,0)", pos1 and pos2 are undefined and findroot() will always return EG_FINDROOTFMT.

#2

Updated by Toomas Soome over 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30

proposed fix is located at:

https://www.illumos.org/rb/r/20/

#3

Updated by Toomas Soome over 4 years ago

  • Category set to lib - userland libraries
  • Assignee set to Toomas Soome
#4

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 30 to 100

git commit 57631629e78d7cda75d1f6ec529fc985298b24f4

commit  57631629e78d7cda75d1f6ec529fc985298b24f4
Author: Toomas Soome <tsoome@me.com>
Date:   2015-04-07T22:04:51.000Z

    5786 Fast reboot broken on EFI formatted drives
    Reviewed by: Richard PALO <richard@NetBSD.org>
    Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF