Project

General

Profile

Actions

Bug #5837

closed

libdtrace audit library build missing LDLIBS

Added by Igor Kozhukhov over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2015-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

+ /usr/gcc/4.8/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused-label -Wno-unused-variable -Wno-parentheses -Wno-uninitialized -Wno-switch -Wno-clobbered -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -fPIC -DTEXT_DOMAIN="SUNW_OST_OSLIB" -D_TS_ERRNO -I/myshare/builds/ssd02/builds/dilos-illumos.lx/proto/root_i386/usr/include -I../common -I. -I/myshare/builds/ssd02/builds/dilos-illumos.lx/usr/src/common/dis/i386 -o libdtrace_forceload.so -shared -hlibdtrace_forceload.so -Wl,-ztext -Wl,-zdefs -Wl,-Bdirect -Wl,-M/myshare/builds/ssd02/builds/dilos-illumos.lx/usr/src/common/mapfiles/common/map.pagealign -Wl,-M/myshare/builds/ssd02/builds/dilos-illumos.lx/usr/src/common/mapfiles/common/map.noexdata pics/dlink_audit.o pics/dlink_common.o -lmapmalloc -lc -lproc 
ld: fatal: library -lmapmalloc: not found
ld: fatal: library -lproc: not found
ld: fatal: file processing errors. No output written to libdtrace_forceload.so
collect2: error: ld returned 1 exit status

Related issues

Related to illumos gate - Bug #5468: Missing dependencies in lib/MakefileClosedYuri Pankov2014-12-21

Actions
Actions #1

Updated by Igor Kozhukhov over 6 years ago

proposed fix:

diff --git a/usr/src/lib/libdtrace/Makefile.com b/usr/src/lib/libdtrace/Makefile.com
index cf8f24f..614edd1 100644
--- a/usr/src/lib/libdtrace/Makefile.com
+++ b/usr/src/lib/libdtrace/Makefile.com
@@ -235,7 +235,7 @@ $(DRTIOBJ): $(DRTIOBJS)

 $(LIBDAUDIT): $(LIBDAUDITOBJS)
        $(LINK.c) -o $@ $(GSHARED) -h$(LIBDAUDIT) $(ZTEXT) $(ZDEFS) $(BDIRECT) \
-           $(MAPFILE.PGA:%=-M%) $(MAPFILE.NED:%=-M%) $(LIBDAUDITOBJS) \
+           $(MAPFILE.PGA:%=-M%) $(MAPFILE.NED:%=-M%) $(LDLIBS) $(LIBDAUDITOBJS) \
            -lmapmalloc -lc -lproc
        $(POST_PROCESS_SO)

Actions #2

Updated by Andrew Stormont over 6 years ago

  • Related to Bug #5834: Remove dependency on sysidtool added
Actions #3

Updated by Andrew Stormont over 6 years ago

  • Related to deleted (Bug #5834: Remove dependency on sysidtool)
Actions #4

Updated by Andrew Stormont over 6 years ago

  • Related to Bug #5468: Missing dependencies in lib/Makefile added
Actions #5

Updated by Robert Mustacchi over 6 years ago

  • Subject changed from libdtrace_forceload.so build failed if we have no .so links to libs on build host to libdtrace_forceload.so build needs LDLIBS
  • Category set to lib - userland libraries
  • % Done changed from 0 to 90
  • Difficulty changed from Medium to Bite-size
  • Tags deleted (needs-triage)
Actions #6

Updated by Robert Mustacchi over 6 years ago

  • Subject changed from libdtrace_forceload.so build needs LDLIBS to libdtrace audit library build missing LDLIBS
Actions #7

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 7721f1230adeb792b06df9580f9696d03ff5911d

commit  7721f1230adeb792b06df9580f9696d03ff5911d
Author: Robert Mustacchi <rm@joyent.com>
Date:   2015-04-16T14:42:54.000Z

    5837 libdtrace audit library build missing LDLIBS
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF