Project

General

Profile

Actions

Bug #5854

closed

pfexecd should initialize pfexec response buffers

Added by Robert Mustacchi almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
2015-04-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

pfexecd's callback_pfexec() uses variable sized data to reply to a door routine. This is allocated with alloca; however, it doesn't always initialize its contents, particularly when we hit cases when we're unauthorized or just have a plain old standard exec. This can later trip up the error handling routines in pfexec_call() in the kernel because the door callback claims we have more data than the size, causing us to take the error path.

Actions #1

Updated by Electric Monk almost 7 years ago

  • Status changed from Pending RTI to Closed

git commit b01b59e369b297df1b370a7ef94d2b9230d04452

commit  b01b59e369b297df1b370a7ef94d2b9230d04452
Author: Robert Mustacchi <rm@joyent.com>
Date:   2015-04-17T17:10:38.000Z

    5853 pfexec_call() error handling could be improved
    5854 pfexecd should initialize pfexec response buffers
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Steven Williamson <steve@freeagent.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF