psiginfo arguments should be const
According to POSIX, psiginfo's arguments should all be specified as const, but ours does not. From usr/src/head/siginfo.h :
extern void psiginfo(siginfo_t *, char *);
Based on http://pubs.opengroup.org/stage7tc1/functions/psiginfo.html I think it should look like this:
extern void psiginfo(const siginfo_t *, const char *);
Note that psignal(3C) looks to be compliant, so perhaps this was just an oversight?
Updated by Eric Sproul over 6 years ago
During review, the issue of testing compliance for psiginfo and psignal was raised. During said testing, we realized that these functions are not properly scoped to the standards level where they were introduced. Issue #5875 is open to address that bug, as well as to expand signal.h test coverage.
Updated by Electric Monk about 6 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 3e5de5d019b8b1edc6c40c035fa29f3a41341841 Author: Eric Sproul <email@example.com> Date: 2015-04-28T18:14:23.000Z 5863 psiginfo arguments should be const Reviewed by: Andy Stormont <firstname.lastname@example.org> Reviewed by: Garrett D'Amore <email@example.com> Reviewed by: Dan McDonald <firstname.lastname@example.org> Approved by: Garrett D'Amore <email@example.com>