Actions
Bug #5909
closedzfs_ioc_promote does not check new name length for shared snapshots
Status:
Closed
Priority:
High
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2015-05-05
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
Description
Or, more specifically, this should be a job of dsl_dataset_promote_check()
.
Right now, if a clone has a longer name that a dataset from which it was branched, then the promotion of the clone may result in a snapshot name that's longer than MAXNAMELEN
, because the shared snapshots are reassigned to the promoted dataset.
The too long name leads to several problem...
Updated by Andriy Gapon about 7 years ago
Proposed fix: https://reviews.csiden.org/r/219/
Updated by Electric Monk almost 7 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit cb5842f8b0caaad0ed53535bd77042e933fdbafe
commit cb5842f8b0caaad0ed53535bd77042e933fdbafe Author: Andriy Gapon <avg@freebsd.org> Date: 2015-05-27T14:51:23.000Z 5909 ensure that shared snap names don't become too long after promotion Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com>
Actions