Project

General

Profile

Feature #5916

make libsqlite a real shared lib

Added by Gordon Ross over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2015-05-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The embedded copy of sqlite 2.8.15 used by svccfgd, idmapd, and smbd, is
currently built as a relocatable object and linked with svccfgd and idmapd.
This was an extremist effort to prevent 3rd party applications from finding
and using the system's libsqlite shared object (if it were to use one).

Unfortunately, that really makes life much more difficult than it needs to be
when debugging either idmap or svc.configd code, as there's no easy way to
get dtrace probes in just the (real) main program and not all the libsqlite code.
It also slows edit, compile, debug cycles when dealing with these consumers.

Let's go ahead and let svc.configd and idmapd use a real shared object for
libsqlite. Note that smbd already builds and installs a libsqlite.so.version
(though not in a place applications normally look).

As for preventing 3rd party applications from using it:
It should be enough to just not install a *.so link for this library
and use a name that won't conflict with libsqlite.so.*

History

#1

Updated by Gordon Ross over 5 years ago

  • Tracker changed from Bug to Feature
#2

Updated by Electric Monk about 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 91d7f85e02991954d1e1bd44673df567ad8dcc87

commit  91d7f85e02991954d1e1bd44673df567ad8dcc87
Author: Gordon Ross <gwr@nexenta.com>
Date:   2015-06-01T03:16:21.000Z

    5916 make libsqlite a real shared lib
    Reviewed by: Thomas Keiser <thomas.keiser@nexenta.com>
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Approved by: Garrett D'Amore <garrett@damore.org>

#3

Updated by Gordon Ross about 5 years ago

  • Description updated (diff)
#4

Updated by Gordon Ross about 5 years ago

  • Description updated (diff)
#5

Updated by Electric Monk about 5 years ago

git commit 9e7640efa0543abb3896339db6a874f0bb6f2e04

commit  9e7640efa0543abb3896339db6a874f0bb6f2e04
Author: Gordon Ross <gwr@nexenta.com>
Date:   2015-06-01T20:57:26.000Z

    5916 make libsqlite a real shared lib (if. chk. noise)

Also available in: Atom PDF