Project

General

Profile

Feature #5997

FRU field not set during pool creation and never updated

Added by Hans Rosenfeld over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2015-06-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

ZFS already supports storing the vdev FRU in a vdev property. There is code in libzfs to work with this property, and there is code in the zfs-retire FMA module that looks for that information. But there is no code actually setting or updating the FRU.

To address this, ZFS is changed to send a handful of new events whenever a vdev is added, attached, cleared, or onlined, as well as when a pool is created or imported. The syseventd zfs module will handle these and update the FRU field when necessary.

History

#1

Updated by Hans Rosenfeld over 4 years ago

I tested this using a test machine with a 8-disk jbod attached. I created a pool on four disks, removed the other four disk, and then shuffled the pool disks around in various situations. I have verified that the FRU property is set when a pool is created, or a vdev is attached, or added. I also verified that the FRU is updated when a pool is imported, or a vdev is onlined, or cleared. I also made sure the FRU is only updated when really needed.

#2

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2750f8d5ec1b891560ac2224f6c37243d910bd1b

commit  2750f8d5ec1b891560ac2224f6c37243d910bd1b
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2015-06-19T18:06:14.000Z

    5997 FRU field not set during pool creation and never updated
    Reviewed by: Dan Fields <dan.fields@nexenta.com>
    Reviewed by: Josef Sipek <josef.sipek@nexenta.com>
    Reviewed by: Richard Elling <richard.elling@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

#3

Updated by Electric Monk over 4 years ago

git commit 1437283407f89cab03860accf49408f94559bc34

commit  1437283407f89cab03860accf49408f94559bc34
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2015-08-27T14:55:45.000Z

    5997 FRU field not set during pool creation and never updated
    Reviewed by: Dan Fields <dan.fields@nexenta.com>
    Reviewed by: Josef Sipek <josef.sipek@nexenta.com>
    Reviewed by: Richard Elling <richard.elling@gmail.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF