Project

General

Profile

Bug #6025

Customer cannot set Share Properties using MMC

Added by Gordon Ross over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
2015-06-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

If anything changes libshare after the SMB server starts (i.e. changes from outside SMB) then using MMC to modify share properties fails.

#1

Updated by Gordon Ross over 5 years ago

  • Category set to cifs - CIFS server and client
#2

Updated by Gordon Ross over 5 years ago

With dtrace on a system exhibiting this problem we were able to narrow this down to the relationship between smbd and libshare. When smbd calls libshare/sa_find_share, the failing case does not find as many share groups as the success case. That lead me to examine how the share handle gets updated, and to my surprise, apparently nothing updates it.
The other consumer of libshare using a "long lived handle" like this is libzfs, and that arranges to call sa_needs_refresh() on it's handle with some regularity. Seems that was missing from the smbd consumer.

#3

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit a851ffc82d02870137b4065c395d79bec1172c32

commit  a851ffc82d02870137b4065c395d79bec1172c32
Author: Gordon Ross <gwr@nexenta.com>
Date:   2015-10-04T15:58:43.000Z

    6025 Customer cannot set Share Properties using MMC
    Reviewed by: Alek Pinchuk <alek@nexenta.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF