Project

General

Profile

Bug #6052

decouple lzc_create() from the implementation details

Added by Andriy Gapon about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2015-07-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

At the moment type parameter of lzc_create() is of dmu_objset_type_t type.
That exposes an implementation detail and requires sys/fs/zfs.h to be included in libzfs_core.h creating unnecessary coupling between libzfs_core interface and ZFS internals.
I think that dmu_objset_type_t should be replaced with a libzfs_core enumeration of supported dataset types.
For ABI reasons the new enumeration could be bit-compatible with dmu_objset_type_t.
For example:

    typedef enum {
        LZC_DST_ZFS = 2,
        LZC_DST_ZVOL
    } lzc_dataset_type_t;

History

#1

Updated by Electric Monk over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 26455f9efcf9b1e44937d4d86d1ce37b006f25a9

commit  26455f9efcf9b1e44937d4d86d1ce37b006f25a9
Author: Andriy Gapon <andriy.gapon@clusterhq.com>
Date:   2016-04-21T15:29:18.000Z

    6052 decouple lzc_create() from the implementation details
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF