Project

General

Profile

Actions

Bug #6119

closed

mptsas doesn't handle timeouts in mptsas_get_sata_guid()

Added by Hans Rosenfeld over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2015-08-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

When a SATA device is connected to an mpt_sas device the driver will try to get the SATA GUID by sending an INQUIRY command. For this to work a temporary mptsas_target_t is created that is not inserted into the target refhash. As the timeout watchdog only scans the devices in the refhash for timed out commands it is essentially blind for timeouts of that certain INQUIRY command. As a result the event handling thread of mptsas gets stuck in scsi_transport() waiting forever for the command to complete.

We found this with a certain Toshiba SATA SSD which can take 17s or even more to reply an INQUIRY on hotplug.

Actions

Also available in: Atom PDF