Project

General

Profile

Actions
Copy link

Bug #6131

closed

struct scsi_device uses a 1-bit signed bitfield

Added by Josef Sipek almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Josef Sipek
Category:
kernel
Start date:
2015-08-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

1-bit wide bitfields can be very useful, however when they are signed things get a bit murky - are the values represented 0 and 1 or 0 and -1? Some static analysis tools warn about this.

Actions
Copy link
 #1

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit e6e1c9deb3babfde63f6fe6096a2eb3214c8f7df

commit  e6e1c9deb3babfde63f6fe6096a2eb3214c8f7df
Author: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Date:   2015-08-23T16:05:43.000Z

    6131 struct scsi_device uses a 1-bit signed bitfield
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF