Bug #6159
closed
Feature #6080: libbe should support installboot
Feature #6085: export libbe installboot function
libbe should proactively handle future architectures
100%
Description
Currently in libbe there's a bunch of logic which is generally of the form:
if (x86) {
...
} else {
do sparc specific actions
}
This should be rephrased to something like:
if (x86) {
...
} else if (sparc) {
...
} else {
<raise unknown architecture error>
}
Updated by Toomas Soome about 7 years ago
- Parent task set to #6085
- Difficulty changed from Medium to Bite-size
reviewboard request https://www.illumos.org/rb/r/88/
to keep my task order under the control, I did build this update on top of #6085.
The actual architecture dependency is in single code branch, therefore the fix is really simple. Note, even as current be_has_grub() is also built around be_is_isa("i386") check, this check in current point of time is valid and has to be changed when i386 can have different loaders. The contexts where be_has_grub() is called in code are really about either grub menu file or grub (version) management, and therefore be_has_grub() calls seem to be valid - at least I haven't spotted any problems with be_has_grub() calls in loader project, where i386 does have both grub and loader available.
Updated by Toomas Soome about 7 years ago
- Status changed from New to Pending RTI
Updated by Electric Monk about 7 years ago
- Status changed from Pending RTI to Closed
- % Done changed from 0 to 100
git commit 66f18efa654be2a490581b727f9b09dcd174aded
commit 66f18efa654be2a490581b727f9b09dcd174aded
Author: Toomas Soome <tsoome@me.com>
Date: 2015-09-23T16:07:23.000Z
6159 libbe should proactively handle future architectures
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Richard Lowe <richlowe@richlowe.net>