Project

General

Profile

Actions

Bug #616

closed

euc code in libc not aligned with localedef

Added by Garrett D'Amore over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Category:
lib - userland libraries
Start date:
2011-01-08
Due date:
% Done:

0%

Estimated time:
Difficulty:
Tags:
Gerrit CR:

Description

The support in libc for euc encodings has special code for EUC, whereby each of the variations is handled via a "variable" which provides additional logic.

Localedef's approach is much saner, where EUC-CN, EUC-KR, EUC-JP, and EUC-TW are each treated as separate encodings.

The fact that these two are in disagreement means that none of the EUC encodings can be used.

We need to make libc's look like localedefs.

At the same time, we can remove some of the special casing checks for EUC from libc.

Actions #1

Updated by Garrett D'Amore over 10 years ago

  • Category set to lib - userland libraries
  • Assignee set to Garrett D'Amore
Actions #2

Updated by Garrett D'Amore over 10 years ago

Webrev here:

http://mexico.purplecow.org/gdamore/webrev/euc/

It compiles and lints cleanly at least. I don't have any experience or data for EUC, so I can only assume this is correct. If it is incorrect, then at least it should be incorrect consistently with localedef.

Actions #3

Updated by Garrett D'Amore over 10 years ago

  • Status changed from New to Resolved

This is now integrated into

changeset: 13264:1a29e6379e8a
tag: tip
user: Garrett D'Amore <>
date: Thu Jan 13 08:38:20 2011 -0800
description:
616 euc code in libc not aligned with localedef
Reviewed by:
Reviewed by:
Approved by:

Actions

Also available in: Atom PDF