Project

General

Profile

Bug #6190

libsmbios checks against the wrong version

Added by Robert Mustacchi over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2015-08-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Currently the smbios routines encode knowledge about two different things, the version of the library that the consumer is using and the version of the smbios that the hardware uses.

Throughout the code we are mistakenly using the hardware version as opposed to the library version. This is even more unfortunate because the hardware version is actually stored as a uint32_t in such a way that it will always be larger than all of the library versions which are stored as a uint16_t, thus causing us to always do the wrong thing.

#1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 6734c4b0468cc77a7871a5dd5c23a5562557d64c

commit  6734c4b0468cc77a7871a5dd5c23a5562557d64c
Author: Robert Mustacchi <rm@joyent.com>
Date:   2015-09-15T21:36:17.000Z

    6189 want smbios 3.0 support
    6190 libsmbios checks against the wrong version
    6191 libsmbios can be a bit more forgiving to the past
    6192 smbios misprints extended onboard devices
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF