Project

General

Profile

Actions

Feature #6191

closed

libsmbios can be a bit more forgiving to the past

Added by Robert Mustacchi almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2015-08-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Currently the common smbios routines have a notion of an encoded library version. However, it doesn't actually honor that in some of the structure bzeroing that it does, thus creating implicit flag days for all consumers. Instead, as part of the process to bring things library to a more stable interface, we should instead make sure to honor the block comment in the library and only zero things out appropriately based on the library version.

Actions #1

Updated by Electric Monk almost 6 years ago

  • Status changed from New to Closed

git commit 6734c4b0468cc77a7871a5dd5c23a5562557d64c

commit  6734c4b0468cc77a7871a5dd5c23a5562557d64c
Author: Robert Mustacchi <rm@joyent.com>
Date:   2015-09-15T21:36:17.000Z

    6189 want smbios 3.0 support
    6190 libsmbios checks against the wrong version
    6191 libsmbios can be a bit more forgiving to the past
    6192 smbios misprints extended onboard devices
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF