Project

General

Profile

Bug #6198

Let's EOL cachefs

Added by Dan McDonald about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2015-09-02
Due date:
2015-09-12
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Nobody uses it, and #6197 is taking the first step by nuking it in the startup scripts.


Related issues

Related to illumos gate - Bug #6197: get rid of unused checks in fs-root and fs-usr boot scriptsClosed2015-09-02

Actions
Related to illumos gate - Bug #6261: Fix for 6198 overlooked NULL abuse in svr4pkg/libinst/mntinfo.cNew2015-09-24

Actions

History

#1

Updated by Alexander Eremin about 4 years ago

  • Assignee set to Alexander Eremin
#2

Updated by Josef Sipek about 4 years ago

  • Related to Bug #6197: get rid of unused checks in fs-root and fs-usr boot scripts added
#3

Updated by Alexander Eremin about 4 years ago

  • Due date set to 2015-09-12
  • Status changed from New to Pending RTI
  • % Done changed from 0 to 90
#4

Updated by Electric Monk about 4 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit bd93c05dbd9b8f1e8d2edf48c777bc881f927608

commit  bd93c05dbd9b8f1e8d2edf48c777bc881f927608
Author: Alexander Eremin <a.eremin@nexenta.com>
Date:   2015-09-22T18:01:25.000Z

    6198 Let's EOL cachefs
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

#5

Updated by Richard PALO about 4 years ago

This patchset kept two NULL bugs in the following file, the first one directly.

diff --git a/usr/src/cmd/svr4pkg/libinst/mntinfo.c b/usr/src/cmd/svr4pkg/libinst/mntinfo.c
index 0867628..44fda5c 100644
--- a/usr/src/cmd/svr4pkg/libinst/mntinfo.c
+++ b/usr/src/cmd/svr4pkg/libinst/mntinfo.c
@@ -223,7 +223,7 @@ get_server_host(uint32_t n)
        if (n < fs_tab_used) {
                (void) strcpy(hostname, fs_tab[n]->remote_name);
                if ((host_end = strchr(hostname, ':')) == NULL) {
-                       if ((strcmp(fs_tab[n]->fstype, MNTTYPE_AUTOFS)) == NULL)
+                       if ((strcmp(fs_tab[n]->fstype, MNTTYPE_AUTO)) == 0)
                                return ("automounter");
                        else
                                return (fs_tab[n]->fstype);
@@ -1121,7 +1121,7 @@ fsys(char *path)
                 * do the string compare. -- JST
                 */
                if ((fs_namelen == 1 && *(fs_tab[i]->name) == '/') ||
-                   ((term_char == '/' || term_char == NULL) &&
+                   ((term_char == '/' || term_char == '\0') &&
                    strncmp(fs_tab[i]->name, path2use, fs_namelen) == 0)) {
                        return (i);
                }

#6

Updated by Dan McDonald about 4 years ago

I'm opening up a new issue to track this. It'll make a good introduction for someone.

#7

Updated by Dan McDonald about 4 years ago

  • Related to Bug #6261: Fix for 6198 overlooked NULL abuse in svr4pkg/libinst/mntinfo.c added

Also available in: Atom PDF