Actions
Bug #6199
openrpc(3nsl): The XDR structure formatting needs improvements
Status:
New
Priority:
Low
Assignee:
-
Category:
manpage - manual pages
Start date:
2015-09-03
Due date:
% Done:
0%
Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
Description
The XDR structure in the rpc(3nsl) needs some improvements. It is listed in the man page as follows:
typedef struct { enum xdr_op x_op; /* operation; fast additional param */ struct xdr_ops { bool_t (*x_getlong)(); /* get long from underlying stream */ bool_t (*x_putlong)(); /* put long to underlying stream */ bool_t (*x_getbytes)(); /* get bytes from underlying stream */ bool_t (*x_putbytes)(); /* put bytes to underlying stream */ uint_t (*x_getpostn)(); /* returns bytes off from beginning */ bool_t (*x_setpostn)(); /* reposition the stream */ rpc_inline_t *(*x_inline)(); /* buf quick ptr to buffered data */ void (*x_destroy)(); /* free privates of this xdr_stream */ bool_t (*x_control)(); /* changed/retrieve client object info*/ bool_t (*x_getint32)(); /* get int from underlying stream */ bool_t (*x_putint32)(); /* put int to underlying stream */ } *x_ops; caddr_t x_public; /* users' data */ caddr_t x_priv /* pointer to private data */ caddr_t x_base; /* private used for position info */ int x_handy; /* extra private word */ XDR;
Here are the issues:
- The XDR structure is dumped from usr/src/lib/libbc/inc/include/rpc/xdr.h, which is obsolete, no longer used and not distributed version of the header file. Currently the XDR structure is defined in usr/src/uts/common/rpc/xdr.h.
- There is missing ending curly bracket between the x_handy member and XDR.
- The x_priv should be changed to x_private. There is missing semicolon on the same line too.
No data to display
Actions