Project

General

Profile

Bug #626

mptsas warning should be removed

Added by Garrett D'Amore almost 9 years ago. Updated about 8 years ago.

Status:
New
Priority:
Low
Category:
-
Start date:
2011-01-12
Due date:
% Done:

20%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

The following warning can be disconcerting when it shows up:

mptsas_log(mpt, CE_NOTE, "ddi_intr_get_nvail returned %d, " 
"navail() returned %d", count, avail);

This happens if the system has fewer available interrupts than the device would like to request. Of course, this messaging occurs just prior to an assignment (unconditional) of 1 to count, since the mptsas driver can't take advantage of multiple system interrupts anyway.

There's also an inherent race here, as the driver asks for the available count, which may be immediately stale, prints the message, and then explicitly asks for one.

Given this, we should remove the check for avail, and warn only if we failed to allocate an interrupt.

Note that in NexentaStor we just disable the warning, which is probably not quite the right answer here.

History

#1

Updated by Alexander Eremin about 8 years ago

  • Assignee set to Alexander Eremin
  • % Done changed from 0 to 20
  • Difficulty set to Medium
  • Tags set to needs-triage

Also available in: Atom PDF