Project

General

Profile

Bug #6263

add missing cc clobbers to intel atomic inlines

Added by Josef Sipek about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2015-09-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

On x86, the inc/dec/add/or/and instructions set [er]flags according to the result of the calculation. This means that the atomic_* static inlines need to specify the "cc" clobber register otherwise we risk the compiler not realizing that the flags have changed and suble bugs appearing.

History

#1

Updated by Josef Sipek about 4 years ago

  • Description updated (diff)
#2

Updated by Electric Monk about 4 years ago

  • Status changed from New to Closed
  • % Done changed from 50 to 100

git commit 6a9ca708361200b105f7a016216808e6058d17cb

commit  6a9ca708361200b105f7a016216808e6058d17cb
Author: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Date:   2015-09-29T17:07:49.000Z

    6263 add missing cc clobbers to intel atomic inlines
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF