Project

General

Profile

Bug #6295

metaslab_condense's dbgmsg should include vdev id

Added by Matthew Ahrens over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Matthew Ahrens
Category:
zfs - Zettabyte File System
Start date:
2015-10-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

seems like this should include the vdev id, otherwise the metaslab id is kinda useless:
spa_dbgmsg(spa, "condensing: txg %llu, msp[%llu] %p, "
"smp size %llu, segments %lu, forcing condense=%s", txg,
msp->ms_id, msp, space_map_length(msp->ms_sm),
avl_numnodes(&msp->ms_tree->rt_root),
msp->ms_condense_wanted ? "TRUE" : "FALSE");

#1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit daec38ecb4fb5e73e4ca9e99be84f6b8c50c02fa

commit  daec38ecb4fb5e73e4ca9e99be84f6b8c50c02fa
Author: Joe Stein <joe.stein@delphix.com>
Date:   2015-10-10T23:21:05.000Z

    6295 metaslab_condense's dbgmsg should include vdev id
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Andriy Gapon <avg@freebsd.org>
    Reviewed by: Xin Li <delphij@freebsd.org>
    Reviewed by: Justin Gibbs <gibbs@scsiguy.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF