Project

General

Profile

Bug #6315

taskq kstat uses the wrong label

Added by Robert Mustacchi over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2015-10-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Look at the following definition from taskq.c:

 586 /*
 587  * Task queues kstats.
 588  */
 589 struct taskq_kstat {
 590         kstat_named_t   tq_pid;
 591         kstat_named_t   tq_tasks;
 592         kstat_named_t   tq_executed;
 593         kstat_named_t   tq_maxtasks;
 594         kstat_named_t   tq_totaltime;
 595         kstat_named_t   tq_nalloc;
 596         kstat_named_t   tq_nactive;
 597         kstat_named_t   tq_pri;
 598         kstat_named_t   tq_nthreads;
 599 } taskq_kstat = {
 600         { "pid",                KSTAT_DATA_UINT64 },
 601         { "tasks",              KSTAT_DATA_UINT64 },
 602         { "executed",           KSTAT_DATA_UINT64 },
 603         { "maxtasks",           KSTAT_DATA_UINT64 },
 604         { "totaltime",          KSTAT_DATA_UINT64 },
 605         { "nactive",            KSTAT_DATA_UINT64 },
 606         { "nalloc",             KSTAT_DATA_UINT64 },
 607         { "priority",           KSTAT_DATA_UINT64 },
 608         { "threads",            KSTAT_DATA_UINT64 },
 609 };

Note that the nactive label corresponds to the one named tq_nalloc which gets filled with the taskq's tq_nalloc member. The opposite is true with the nalloc label which has the nactive label.


Related issues

Has duplicate illumos gate - Bug #5143: taskq kstat labels out of orderClosed2014-09-10

Actions
#1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed

git commit 7c5f01c17875fc96e2b6119c01a189afd6081e87

commit  7c5f01c17875fc96e2b6119c01a189afd6081e87
Author: Robert Mustacchi <rm@joyent.com>
Date:   2015-10-13T05:20:40.000Z

    6315 taskq kstat uses the wrong label
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Matthew Ahrens <mahrens@delphix.com>

#2

Updated by Joshua M. Clulow almost 2 years ago

  • Has duplicate Bug #5143: taskq kstat labels out of order added

Also available in: Atom PDF