Bug #6341
closed
virtio doesn't try hard enough to get MSI interrupts
0%
Description
virtio_register_msi() doesn't seem to try hard enough with MSI. Specifically, suppose the system supports MSIX, MSI, and FIXED. virtio_register_msi() will try to register MSIX interrupts. Suppose that fails. Instead of moving onto the next preferred one (MSI), it bails. Then virtio_register_ints() tries to salvage the situation by calling virtio_register_intx() to register FIXED interrupts. This seems suboptimal. It should try to get MSI before totally giving up on MSI-type interrupt.
Related issues
Updated by Josef Sipek almost 8 years ago
- Blocked by Bug #6166: fix MSI-X support in virtio driver added
Updated by Joshua M. Clulow about 3 years ago
- Status changed from New to Rejected
- Tags deleted (
needs-triage)
I reworked the interrupt allocation behaviour in #11329, so I don't think this applies any longer. Note that although the original code needed improvement, the omission of MSI interrupts is actually (it seems) on account the Virtio specification; it specifies a way to use MSI-X but not MSI interrupt vectors.
Updated by Joshua M. Clulow about 3 years ago
- Related to Feature #11329: improved Virtio framework added