Project

General

Profile

Feature #6342

want signalfd support

Added by Robert Mustacchi about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2015-10-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

We'd like to add support for signalfd() which is generally useful and provides support for people porting software from Linux to illumos, as well as enables the lx brand.

#1

Updated by Robert Mustacchi about 5 years ago

  • Subject changed from want signalfd support to want signalfd support
#2

Updated by Robert Mustacchi about 5 years ago

  • Subject changed from want signalfd support to want signalfd support
#3

Updated by Electric Monk about 5 years ago

  • Status changed from New to Closed

git commit 3d729aecc03ea6ebb9bd5d56b8dccd24f57daa41

commit  3d729aecc03ea6ebb9bd5d56b8dccd24f57daa41
Author: Jerry Jelinek <jerry.jelinek@joyent.com>
Date:   2015-11-16T17:44:54.000Z

    6342 want signalfd support
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@omniti.com>

#4

Updated by Richard PALO about 5 years ago

Electric Monk wrote:

git commit 3d729aecc03ea6ebb9bd5d56b8dccd24f57daa41
[...]

NULL constant pointer is not an int patch

diff --git a/usr/src/uts/common/io/signalfd.c b/usr/src/uts/common/io/signalfd.c
index 32f8f85..d042470 100644
--- a/usr/src/uts/common/io/signalfd.c
+++ b/usr/src/uts/common/io/signalfd.c
@ -643,7 +643,7 @ signalfd_attach(dev_info_t *devi, ddi_attach_cmd_t cmd)
}

if (ddi_create_minor_node(devi, "signalfd", S_IFCHR,
- SIGNALFDMNRN_SIGNALFD, DDI_PSEUDO, NULL) DDI_FAILURE) {
+ SIGNALFDMNRN_SIGNALFD, DDI_PSEUDO, 0) DDI_FAILURE) {
cmn_err(CE_NOTE, "/dev/signalfd couldn't create minor node");
ddi_soft_state_fini(&signalfd_softstate);
id_space_destroy(signalfd_minor);
#5

Updated by Gary Mills about 5 years ago

This is probably the most common erroneous use of NULL that I've seen. The last parameter of ddi_create_minor_node is flag expressed as an integer. Does everybody just copy the function call from someplace else?

Also available in: Atom PDF