Project

General

Profile

Bug #6349

tools build of make should not use CPPFLAGS.native

Added by Gordon Ross over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2015-10-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Due to some earlier issues (apparently resolved before make integrated), CPPFLAGS.native was used in usr/src/tools/make/Makefile.com
In general, CPPFLAGS.native should be avoided for building things that run on the build system, because it inflicts potentially any and all headers in the ON proto area on the native build.
(This means CPPFLAGS.native must be used very selectively, if ever.)

It's simply not need here, and using it breaks building native on some systems.

#1

Updated by Electric Monk over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit cf397aabe4e38964cfeb03e56ca8b407986c3a10

commit  cf397aabe4e38964cfeb03e56ca8b407986c3a10
Author: Gordon Ross <gwr@nexenta.com>
Date:   2015-10-22T18:42:09.000Z

    6349 tools build of make should not use CPPFLAGS.native
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF